integration_tests: Speed up CI run time (SC-612)#1111
Merged
Conversation
Move more tests into test_combined.py and remove the CI mark from module tests that aren't updated often or don't represent core functionality.
TheRealFalcon
changed the title
TheRealFalcon
changed the title
blackboxsw
approved these changes
Nov 17, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
All good with consolidating unrelated modules into test_combined in general. If we run into failure scenarios because of interaction between those modules(unlikely), we can separate them back out. Likewise, if we find that the removal of pytest.mark.ci leads to frequent failures on our daily build after branches have landed, we can opt to re-integrate those tests in per-PR CI runs.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Removed files have been merged into test_combined.py. All tests will still get run daily on our internal jenkins instance. This is for travis and tests that block merging.