docs: Rename HACKING.rst to CONTRIBUTING.rst (SC-501)#1118
Merged
Conversation
This is more consistent with other github repositories, and will prompt a first-time contributor to read the contributing guidelines before submitting the pull request. Additionally, added a summary section to the top, updated some outdated language, and removed some outdated typing guidance.
TheRealFalcon
changed the title
blackboxsw
approved these changes
Nov 22, 2021
| the codebase is encouraged but with one important caveat: types from | ||
| the ``typing`` module cannot be used. | ||
|
|
||
| cloud-init still supports Python 3.4, which doesn't have the ``typing`` |
Collaborator
There was a problem hiding this comment.
Woo hoo victory lap on dropped Python 3.4.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
The net refactor stuff seems a bit out of place here, but I didn't move it because there's not an immediately better place to put it, and I think it can be easily ignored for somebody not interested.