Skip to content

Fix exception when no activator found (SC-540)#1129

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:activator-exception
Dec 3, 2021
Merged

Fix exception when no activator found (SC-540)#1129
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:activator-exception

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Proposed Commit Message

Fix exception when no activator found

Given that there are additional network management tools that we haven't
yet supported with activators, we should log a warning and continue
without network activation here, especially since this was a no-op for
years.

LP: #1948681

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Given that there are additional network management tools that we haven't
yet supported with activators, we should log a warning and continue
without network activation here, especially since this was a no-op for
years.

LP: #1948681
@TheRealFalcon TheRealFalcon changed the title Fix exception when no activator found Fix exception when no activator found (SC-540) Dec 2, 2021
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to log a warning here. Let other distros/network stacks add support as needed.

@blackboxsw blackboxsw merged commit ffa6fc8 into canonical:main Dec 3, 2021
@TheRealFalcon TheRealFalcon deleted the activator-exception branch December 3, 2021 04:52
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants