find_devs/openbsd: accept ISO on disk#1132
Merged
TheRealFalcon merged 1 commit intoDec 9, 2021
Merged
Conversation
Contributor
|
@goneri , the change looks good to me, but a few unit tests are failing. Can you fix the failing unit tests? |
goneri
force-pushed
the
find_devs-openbsd-accept-ISO-on-disk_23674
branch
from
bdc9783 to
768b3a0
Compare
When the metadata is an ISO image and is exposed through a disk, the device is called `/dev/sd?a` internally. For instance `/dev/sd1a`. It can then be mounted with `mount_cd9660 /dev/sd1a /mnt`. Metadata in the FAT32 format are exposed as `/dev/sd?i`. With this change, we try to mount `/dev/sd?a` in addition to `/dev/sd?i`. Closes: ContainerCraft/kmi#12
goneri
force-pushed
the
find_devs-openbsd-accept-ISO-on-disk_23674
branch
from
768b3a0 to
7e3089e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the metadata is an ISO image and is exposed through a disk,
the device is called
/dev/sd?ainternally. For instance/dev/sd1a.It can then be mounted with
mount_cd9660 /dev/sd1a /mnt.For comparison, metadata in the FAT32 format are exposed as
/dev/sd?ibecause this time there is a partition table.With this change, cloud-init ttries to mount
/dev/sd?ain addition to/dev/sd?i.Closes: ContainerCraft/kmi#12