Skip to content

docs: Make MACs lowercase in network config (SC-541)#1135

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:mac-docs
Dec 6, 2021
Merged

docs: Make MACs lowercase in network config (SC-541)#1135
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:mac-docs

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Proposed Commit Message

docs: Make MACs lowercase in network config

LP: #1876941

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon TheRealFalcon changed the title docs: Make MACs lowercase in network config docs: Make MACs lowercase in network config (SC-541) Dec 6, 2021
Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped a bit for other spots we might need to update ((:.*){6}) and I didn't find anything. There are a few tests that have uppercase mac addresses, but those look to be mocking output from system commands, so no need to change those. LGTM

@blackboxsw blackboxsw merged commit cd40789 into canonical:main Dec 6, 2021
@TheRealFalcon TheRealFalcon deleted the mac-docs branch December 14, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants