Skip to content

Remove non deterministic test param #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealFalcon merged 4 commits into from
Dec 7, 2021
Merged

Remove non deterministic test param #1138

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d37809
Remove non-deterministic test parameter
holmanb Dec 7, 2021
104796b
fixup
holmanb Dec 7, 2021
dcbdb41
play nice with old pythons
holmanb Dec 7, 2021
5d64fb4
fixup
holmanb Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/unittests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,11 +972,17 @@ def test_is_lxd_false_when_sock_device_absent(self, m_exists):


class TestReadCcFromCmdline:
if hasattr(pytest, "param"):
random_string = pytest.param(
CiTestCase.random_string(), None, id="random_string")
else:
random_string = (CiTestCase.random_string(), None)

@pytest.mark.parametrize(
"cmdline,expected_cfg",
[
# Return None if cmdline has no cc:<YAML>end_cc content.
(CiTestCase.random_string(), None),
random_string,
# Return None if YAML content is empty string.
('foo cc: end_cc bar', None),
# Return expected dictionary without trailing end_cc marker.
Expand Down