Skip to content

travis - don't run integration tests if no deb (SC-699)#1139

Merged
TheRealFalcon merged 5 commits into
canonical:mainfrom
holmanb:holmanb/travis-do-not-run-integration-tests-if-unittests-fail
Dec 9, 2021
Merged

travis - don't run integration tests if no deb (SC-699)#1139
TheRealFalcon merged 5 commits into
canonical:mainfrom
holmanb:holmanb/travis-do-not-run-integration-tests-if-unittests-fail

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Dec 7, 2021 

If building the *.deb fails, exit

Currently integration tests will run and fail with a non-obvious
message. This makes it so the last thing in the logs is whatever
caused the build to fail.

Additional Context

Consider the new output for a failed build:
https://app.travis-ci.com/github/canonical/cloud-init/jobs/551267972

@holmanb holmanb force-pushed the holmanb/travis-do-not-run-integration-tests-if-unittests-fail branch 2 times, most recently from ea7a596 to 6f2f2fc Compare December 7, 2021 23:06
@holmanb holmanb changed the title travis - don't run integration tests if no deb travis - don't run integration tests if no deb (SC-699) Dec 8, 2021
TheRealFalcon
TheRealFalcon reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fail the job in this case? If not, it should.

TheRealFalcon
TheRealFalcon previously approved these changes Dec 8, 2021
View reviewed changes
@holmanb holmanb force-pushed the holmanb/travis-do-not-run-integration-tests-if-unittests-fail branch 2 times, most recently from 4f793eb to ff5fac5 Compare December 8, 2021 21:59
@holmanb holmanb force-pushed the holmanb/travis-do-not-run-integration-tests-if-unittests-fail branch from ae47518 to a3fcc3a Compare December 8, 2021 23:37
TheRealFalcon
TheRealFalcon approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 6760bf1 into canonical:main Dec 9, 2021
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@holmanb @TheRealFalcon