Skip to content

Disable unit tests during integration test run (SC-672)#1141

Merged
TheRealFalcon merged 5 commits into
canonical:mainfrom
holmanb:holmanb/disable-unit-tests-for-integration-tests
Jan 7, 2022
Merged

Disable unit tests during integration test run (SC-672)#1141
TheRealFalcon merged 5 commits into
canonical:mainfrom
holmanb:holmanb/disable-unit-tests-for-integration-tests

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Dec 9, 2021

Remove unittests from integration test job in travis

Currently the integration test job executes unittests as part of package build.
The unittests have their own jobs, so this coverage is redundant and
unnecessary. Save time and remove this test.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@holmanb holmanb changed the title wip - disable unit tests during integration test run wip - disable unit tests during integration test run (SC-672) Dec 9, 2021
@github-actions
Copy link
Copy Markdown

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.)

@github-actions github-actions Bot added the stale-pr Pull request is stale; will be auto-closed soon label Dec 25, 2021
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Dec 25, 2021
@holmanb holmanb force-pushed the holmanb/disable-unit-tests-for-integration-tests branch from ee85a96 to 8bda8e1 Compare January 6, 2022 21:42
@holmanb holmanb force-pushed the holmanb/disable-unit-tests-for-integration-tests branch from 8bda8e1 to e08b867 Compare January 6, 2022 21:43
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Jan 6, 2022

This shaves about 1 minute from the longest running travis test:

Without unittests: 12m 7s
With unittests: 13m 16s (a build from a current PR that doesn't change any integration test files)

The latest commit reverted a failing unit test that was used for validating that unittests were not run during integration testing.

@holmanb holmanb changed the title wip - disable unit tests during integration test run (SC-672) Disable unit tests during integration test run (SC-672) Jan 6, 2022
@TheRealFalcon
Copy link
Copy Markdown
Contributor

Changes look good to me, but I'm still entirely sure all of the use cases of packages/debian and if it's appropriate to disable tests there. @blackboxsw , thoughts?

@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Jan 7, 2022

@TheRealFalcon I undid changes to the debian rules file. I don't think that change actually did anything, and based on the build log output it didn't run the unit tests after undoing that change, so I don't think it was needed. Now it's gone to be safe.

For context: this skips the tests by adding DEB_BUILD_OPTIONS=nocheck env variable to the .travis.yml which causes prevents make check from running in debian/rules

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon merged commit b966f43 into canonical:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants