Skip to content

Include dpkg frontend lock in APT_LOCK_FILES (SC-650)#1153

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:apt-frontend-lock
Dec 15, 2021
Merged

Include dpkg frontend lock in APT_LOCK_FILES (SC-650)#1153
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:apt-frontend-lock

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Additional Context

#1034 (comment)
#1034 (comment)

I also included a link to the first comment in a code comment.

@TheRealFalcon TheRealFalcon changed the title Include dpkg frontend lock in APT_LOCK_FILES Include dpkg frontend lock in APT_LOCK_FILES (SC-650) Dec 13, 2021
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the James. Reasonable to add yet another apt lock file check without additional unittests as we already have coverage for this functionality.

I was able to continue to validate that desired behavior and retries is working by camping on an apt upgrade in a terminal and running cloud-init modules --mode=final with userdata which tries to install packages

2021-12-15 03:21:07,618 - debian.py[DEBUG]: Waiting for apt lock
2021-12-15 03:21:17,631 - debian.py[DEBUG]: apt lock available
2021-12-15 03:21:17,631 - subp.py[DEBUG]: Running command ['eatmydata', 'apt-get', '--option=Dpkg::Options::=--force-confold', '--option=Dpkg::options::=--force-unsafe-io', '--assume-yes', '--quiet', 'update'] with allowed return codes [0] (shell=False, capture=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants