Skip to content

Add support for gentoo templates and cloud.cfg#1179

Merged
TheRealFalcon merged 3 commits into
canonical:mainfrom
vteratipally:gentoo_pkg_update
Jan 20, 2022
Merged

Add support for gentoo templates and cloud.cfg#1179
TheRealFalcon merged 3 commits into
canonical:mainfrom
vteratipally:gentoo_pkg_update

Conversation

@vteratipally
Copy link
Copy Markdown
Contributor

@vteratipally vteratipally commented Jan 11, 2022

Add support for gentoo in cloud.cfg and templates


Add support for gentoo in cloud.cfg and templates.
This is an already existing patch in gentoo upstream https://gitweb.gentoo.org/repo/gentoo.git/tree/app-emulation/cloud-init/files/cloud-init-20.4-gentoo-support-upstream-templates.patch.
Cherry-picking the patch to the upstream cloud-init.

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@holmanb
Copy link
Copy Markdown
Member

holmanb commented Jan 11, 2022

Hi @vteratipally, thanks for the PR. A while ago somebody tried to get something similar merged, but it never landed. I think this is a welcome contribution, but tests don't currently pass. Once tests are passing I can add a review.

I did notice that the cloud-init ebuild in the gentoo repo seems to have duplicate patches listed, which makes me wonder if the gentoo patches even work. Additional context would be helpful. Would you happen to know a) if this package builds cleanly with emerge and b) where/how this package gets used? This information will help with testing.

@vteratipally
Copy link
Copy Markdown
Contributor Author

Yes the gentoo ebuild with the patches works fine. For example, it is used extensively here https://cos.googlesource.com/cos/overlays/board-overlays/+/refs/heads/master/project-lakitu/app-emulation/cloud-init/ for building the cloud-init package into the Container Optimized OS.

Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @vteratipally. This does require a small change, but otherwise I think it's probably good.

Comment thread tools/render-cloudcfg Outdated
@TheRealFalcon
Copy link
Copy Markdown
Contributor

@holmanb , this look good to you now? If so, I can merge it.

@holmanb
Copy link
Copy Markdown
Member

holmanb commented Jan 20, 2022

@TheRealFalcon - Yep, looks good to me!

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 2a08d59 into canonical:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants