Add support for gentoo templates and cloud.cfg#1179
Conversation
|
Hi @vteratipally, thanks for the PR. A while ago somebody tried to get something similar merged, but it never landed. I think this is a welcome contribution, but tests don't currently pass. Once tests are passing I can add a review. I did notice that the cloud-init ebuild in the gentoo repo seems to have duplicate patches listed, which makes me wonder if the gentoo patches even work. Additional context would be helpful. Would you happen to know a) if this package builds cleanly with emerge and b) where/how this package gets used? This information will help with testing. |
|
Yes the gentoo ebuild with the patches works fine. For example, it is used extensively here https://cos.googlesource.com/cos/overlays/board-overlays/+/refs/heads/master/project-lakitu/app-emulation/cloud-init/ for building the cloud-init package into the Container Optimized OS. |
holmanb
left a comment
There was a problem hiding this comment.
Thanks for the feedback @vteratipally. This does require a small change, but otherwise I think it's probably good.
|
@holmanb , this look good to you now? If so, I can merge it. |
|
@TheRealFalcon - Yep, looks good to me! |
Add support for gentoo in cloud.cfg and templates
Additional Context
Test Steps
Checklist: