Skip to content

Seek interfaces, skip dummy, fix region codes#1192

Merged
blackboxsw merged 5 commits into
canonical:mainfrom
eb3095:vultr-nightly
Jan 19, 2022
Merged

Seek interfaces, skip dummy, fix region codes#1192
blackboxsw merged 5 commits into
canonical:mainfrom
eb3095:vultr-nightly

Conversation

@eb3095
Copy link
Copy Markdown
Contributor

@eb3095 eb3095 commented Jan 14, 2022

Proposed Commit Message

Seek interfaces on Vultr opposed to using the first, fix region codes

We were seeing issues where if anything showed up before the expected first adapter, booting could fail. This switches to seeking for a working interface to handle edge cases.

Also fixes region code handling.

Checklist:

  • [ X ] My code follows the process laid out in the documentation
  • [ X ] I have updated or added any unit tests accordingly
  • [ X ] I have updated or added any documentation accordingly

@eb3095 eb3095 changed the title Seek interfaces, skip dummy Seek interfaces, skip dummy, fix region codes Jan 14, 2022
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please run tox -e format so the code passes the black check.

@blackboxsw blackboxsw merged commit 69f9a78 into canonical:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants