cmd: status and cloud-id avoid change in behavior for 'not run'#1197
Merged
blackboxsw merged 1 commit intoJan 19, 2022
Merged
Conversation
snapd currrently looks for 'not run' from cloud-init status[1]. Avoid changing this behavior and revert "not-run" value to "not run". This avoids having to get snapd to change implementation and release updates as far back as Bionic to handle a hyphenated not-run string. [1]: https://github.com/snapcore/snapd/blob/master/sysconfig/\ cloudinit.go#L802
TheRealFalcon
approved these changes
Jan 19, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
+1 assuming CI passes
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to break existing snapd. So, let's leave "not run" value untouched. Also note, if we decide to change cloud-init status exit codes, that also has the potential to break snapd too, so we'd need to float that by that team first and get buyin.
Proposed Commit Message
Additional Context
Test Steps
Checklist: