Skip to content

cmd: status and cloud-id avoid change in behavior for 'not run'#1197

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
blackboxsw:cloud-id-not-run-space-delimited
Jan 19, 2022
Merged

cmd: status and cloud-id avoid change in behavior for 'not run'#1197
blackboxsw merged 1 commit into
canonical:mainfrom
blackboxsw:cloud-id-not-run-space-delimited

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw commented Jan 19, 2022

We don't want to break existing snapd. So, let's leave "not run" value untouched. Also note, if we decide to change cloud-init status exit codes, that also has the potential to break snapd too, so we'd need to float that by that team first and get buyin.

Proposed Commit Message

snapd currrently looks for 'not run' from cloud-init status[1].
Avoid changing this behavior and revert "not-run" value to
"not run".

This avoids having to get snapd to change implementation and
release updates as far back as Bionic to handle a hyphenated
not-run string.

[1]: https://github.com/snapcore/snapd/blob/master/sysconfig/\
     cloudinit.go#L802

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

snapd currrently looks for 'not run' from cloud-init status[1].
Avoid changing this behavior and revert "not-run" value to
"not run".

This avoids having to get snapd to change implementation and
release updates as far back as Bionic to handle a hyphenated
not-run string.

[1]: https://github.com/snapcore/snapd/blob/master/sysconfig/\
     cloudinit.go#L802
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 assuming CI passes

@blackboxsw blackboxsw merged commit 20bd192 into canonical:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants