tests: focal caplog has whitespace indentation for multi-line logs#1201
Merged
TheRealFalcon merged 1 commit intoJan 20, 2022
Merged
Conversation
Avoid series-specific log formatting in tests by using caplog.record_tuples. Added benefit, we can easily check log-level WARNING too. Fixes unit tests from Focal Package builds at: https://code.launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/\ +build/23076508
blackboxsw
force-pushed
the
tests-focal-fix-log-whitespace
branch
from
651d6a0 to
d550ee8
Compare
Member
|
LGTM |
blackboxsw
requested review from
TheRealFalcon and
holmanb
and removed request for
holmanb
TheRealFalcon
approved these changes
Jan 20, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid series-specific log formatting in tests by using
caplog.record_tuples.
Added benefit, we can easily check log-level WARNING too.
Fixes unit test failures from Focal Package builds at:
https://code.launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/23076508
Proposed Commit Message
Additional Context
Test Steps
git checkout upstream/focal get merge tests-focal-fix-log-whitespace build-package sbuild --resolve-alternatives --dist=focal --arch=amd64 --arch-all ../out/cloud-init_21.4-0ubuntu1~20.04.1.dsc # build should succeed instead of failing in unit testsChecklist: