Skip to content

Fix lo being used for DHCP, try next on cmd fail #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealFalcon merged 3 commits into from
Jan 28, 2022
Merged

Fix lo being used for DHCP, try next on cmd fail #1208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c275828
Fix lo being used for DHCP, try next on cmd fail
eb3095 Jan 22, 2022
ce08158
Fix bad logic
eb3095 Jan 24, 2022
2772b60
Fix bad formatting
eb3095 Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cloudinit/sources/helpers/vultr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ def get_metadata(url, timeout, retries, sec_between, agent):

# Seek iface with DHCP
for iface in net.get_interfaces():
# Skip dummy interfaces
# Skip dummy, lo interfaces
if "dummy" in iface[0]:
continue
if "lo" == iface[0]:
continue
try:
with EphemeralDHCPv4(
iface=iface[0], connectivity_url_data={"url": url}
Expand All @@ -33,7 +35,7 @@ def get_metadata(url, timeout, retries, sec_between, agent):

# Fetch the metadata
v1 = read_metadata(url, timeout, retries, sec_between, agent)
except (NoDHCPLeaseError) as exc:
except (NoDHCPLeaseError, subp.ProcessExecutionError) as exc:
LOG.error("DHCP Exception: %s", exc)
exception = exc

Expand Down