Skip to content

RFC - tox changes (SC-763)#1214

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
holmanb:holmanb/tox-changes
Jan 31, 2022
Merged

RFC - tox changes (SC-763)#1214
TheRealFalcon merged 2 commits into
canonical:mainfrom
holmanb:holmanb/tox-changes

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Jan 26, 2022

fix parallel tox execution

Changes:

  • tox -p fails due to a shared directory clobbering files - use unique env dirs to avoid this (this does cause a longer initial serial run due to deps getting installed multiple times)
  • remove unneeded dependencies for black, flake8, and isort environments (saves some CI cycles by avoiding installing unused deps - since travis doesn't share a cache this should be a net gain)
  • add a new environment (for convenience) just for "checking formatting" - this moves current "format" env to "do_format" and adds "check_format". I'm happy to adjust names if others would rather "format" doesn't change or think there is some better naming scheme.

@holmanb holmanb force-pushed the holmanb/tox-changes branch from 414b226 to 470acf0 Compare January 26, 2022 19:48
@holmanb holmanb force-pushed the holmanb/tox-changes branch from 470acf0 to 6c69233 Compare January 26, 2022 20:41
@holmanb holmanb changed the title RFC - tox changes RFC - tox changes (SC-763) Jan 26, 2022
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach looks good. I left some comments inline.

Comment thread tox.ini Outdated
Comment thread tox.ini Outdated
Comment thread tox.ini
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallelize all the things!

@TheRealFalcon TheRealFalcon merged commit 96dca24 into canonical:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants