spell check docs with spellintian (SC-770)#1223
Conversation
eee8a30 to
67f704e
Compare
TheRealFalcon
left a comment
There was a problem hiding this comment.
There goes our possibility of ever joining Hacktoberfest...
I noticed on Travis:
0.46s$ make check_spelling
Makefile:88: recipe for target '_check_spelling' failed
The command "make check_spelling" exited with 0.
I don't think the check is running correctly there. Have we tried with a misspeled word to see if Travis fails on it?
|
#> There goes our possibility of ever joining Hacktoberfest... We have plenty of text files with spelling errors outside of
Fixed. This was some mostly harmless, but I came up with a slightly different solution to prevent that warning. |
67f704e to
8084b35
Compare
8084b35 to
b81637a
Compare
558da2a to
ade5693
Compare
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thanks! This will improve the quality of our docs, and hopefully make us look a little more professional (until people read my PR comments).
Test Steps
revert the bug fixes in the second commit to test the new makefile target functionality
Note that this build fails (before the spelling fixes) and this build succeeds (after the fixes).