Skip to content

docs: include upstream python version info#1230

Merged
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:doc-python
Feb 1, 2022
Merged

docs: include upstream python version info#1230
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:doc-python

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I would like to minimally capture what upstream version folks should expect to require python 3.6 min support in. Take that however you'd like to present the information.

Comment thread CONTRIBUTING.rst

Python Support
--------------
Cloud-init upstream currently supports Python 3.6 and above.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the upstream version of cloud-init v. 22.1 as the point at which the python 3.6 min version support is expected.

Is it worth us trying to preserve a stable-21.4 branch at the cutoff point where 3.5 was dropped for other downstream reference? We did this for our python-2.7 drop via upstream/stable-19.4.
I think there is limited utility for these separate stable-* branches, as I don't think we've seen any downstream PRs against stable-19.4 for instance so I don't know if there is much demand there.

If we did want to capture/doc the python version deprecatoin branches in docs or process, this is the commit where upstream dropped 3.5 support I think is here.

GIven that other distributions might trail upstream significantly. Is it worth us having a table showing last upstream version which supports min python version supported?

cloud-init version min python version
22.1 python 3.6+
20.3 python 3.5+
19.4 python 2.7+

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth us trying to preserve a stable-21.4 branch at the cutoff point where 3.5 was dropped for other downstream reference? We did this for our python-2.7 drop via upstream/stable-19.4.
I think there is limited utility for these separate stable-* branches, as I don't think we've seen any downstream PRs against stable-19.4 for instance so I don't know if there is much demand there.

I don't think we should do that. 2.7->3.x was a huge transition with a ton of breaking changes. Moving between 3.x versions should be much less impactful.

I can capture the table in the doc.

@TheRealFalcon
Copy link
Copy Markdown
Contributor Author

@blackboxsw , included the table in the latest commit

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackboxsw blackboxsw merged commit 490cefd into canonical:main Feb 1, 2022
@TheRealFalcon TheRealFalcon deleted the doc-python branch March 21, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants