Skip to content

cc_salt_minion freebsd fix for rc.conf (SC-782)#1236

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
holmanb:holmanb/salt-freebsd
Feb 4, 2022
Merged

cc_salt_minion freebsd fix for rc.conf (SC-782)#1236
TheRealFalcon merged 2 commits into
canonical:mainfrom
holmanb:holmanb/salt-freebsd

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Feb 3, 2022

cc_salt_minion freebsd fix for rc.conf

This fixes a bug that prevents the salt module from enabling the salt minion in rc.conf.

For more details:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254339

@holmanb holmanb force-pushed the holmanb/salt-freebsd branch from ebef345 to 752bcb8 Compare February 3, 2022 15:19
Copy link
Copy Markdown
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@holmanb holmanb changed the title cc_salt_minion freebsd fix for rc.conf cc_salt_minion freebsd fix for rc.conf (SC-782) Feb 3, 2022
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Normally my mantra would have been more unittests or integration tests.... but

  • no facility currently in upstream integration tests yet to drive BSD runs
  • unittest coverage already covers bsd_utils.set_rc_config_value
  • this changeset is minor enough that given our pylint coverage to assert we haven't bungled the import and existing unittests coverage of bsd_utils/set_rc_config_value, we don't really gain much by instrumenting unittests for this path.

@TheRealFalcon TheRealFalcon merged commit 75a5c8f into canonical:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants