cc_salt_minion freebsd fix for rc.conf (SC-782)#1236
Merged
Conversation
Member
holmanb
commented
Feb 3, 2022
ebef345 to
752bcb8
Compare
blackboxsw
approved these changes
Feb 3, 2022
Collaborator
blackboxsw
left a comment
There was a problem hiding this comment.
LGTM.
Normally my mantra would have been more unittests or integration tests.... but
- no facility currently in upstream integration tests yet to drive BSD runs
- unittest coverage already covers bsd_utils.set_rc_config_value
- this changeset is minor enough that given our
pylintcoverage to assert we haven't bungled the import and existing unittests coverage of bsd_utils/set_rc_config_value, we don't really gain much by instrumenting unittests for this path.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.