Fix extra ipv6 issues, code reduction and simplification

[eb3095]

Proposed Commit Message

Fix extra ipv6 issues, code reduction and simplification

I eliminated the duplicate code and now run the entire configuration routine against both public and private interfaces. I also addressed an inconsistency from our metadata api for ipv6 address configuration.

Test Steps

Start a Vultr vm with additional IPv6's added to the instance.

Checklist:

• [ X ] My code follows the process laid out in the documentation
• [ X ] I have updated or added any unit tests accordingly
• [ X ] I have updated or added any documentation accordingly

[TheRealFalcon]

@eb3095 , changes look good.

Would you be able to add a couple unit tests for this behavior? I think the last PR with the missing continue/return shows we could use some extra unit test coverage for this datasource.

[eb3095]

@eb3095 , changes look good.

Would you be able to add a couple unit tests for this behavior? I think the last PR with the missing continue/return shows we could use some extra unit test coverage for this datasource.

Ha, fair, indeed it could use a few more tests I think. I'll add that.

[eb3095]

Alright, I added tests for all the recent failures and this latest one.

[eb3095]

OK This should be good to go now!

[TheRealFalcon]

LGTM, thanks!