sources/azure: address mypy/pyright typing complaints#1245
Merged
Conversation
anhvoms
approved these changes
Feb 4, 2022
cjp256
force-pushed
the
azure-type-checking
branch
from
07f2a96 to
347804a
Compare
Contributor
Author
|
Depends on #1229 |
cjp256
changed the title
anhvoms
approved these changes
Feb 4, 2022
cjp256
force-pushed
the
azure-type-checking
branch
4 times, most recently
from
a8de074 to
2b9e049
Compare
Raise runtime errors for unhandled cases which would cause other exceptions. Ignore types for a few cases where a non-trivial refactor would be required to prevent the warning. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-type-checking
branch
from
2b9e049 to
1ab6930
Compare
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
I left a number of comments inline. Take or leave what you'd like.
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-type-checking
branch
5 times, most recently
from
0354944 to
3cdbb7c
Compare
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-type-checking
branch
from
fc33511 to
4670981
Compare
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
TheRealFalcon
approved these changes
Feb 10, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
LGTM! Got a conflict now though from me merging the other PR first.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.