use PEP 589 syntax for TypeDict#1253
Merged
Merged
Conversation
334a103 to
1f81085
Compare
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
The old version had
if sys.version_info >= (3, 8) and hasattr(typing, "TypeDict"):That's TypeDict rather than TypedDict, so this never actually worked.
In order for this proposed version to work, we also need to add this type to every meta definition because apparently you can't coerce a raw dict into a TypedDict. E.g., on cc_apk_configure, I currently see:

Can we update these meta definitions in this PR too?
| ) | ||
| if sys.version_info >= (3, 8): | ||
|
|
||
| class MetaSchema: |
Contributor
There was a problem hiding this comment.
This needs to inherit from TypedDict.
ea5a634 to
6f730cc
Compare
Member
Author
|
@TheRealFalcon I rebased on the new mypy commit and it looks like the fix you suggested allows us to remove a couple of files from the "exclude" list. This is ready for re-review. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.