sources/azure: removed unused savable PPS paths#1268
Merged
Conversation
If the VM is rebooted during provisioning, the PPS type will be determined to be UNKNOWN and will poll for reprovision data. Given that we will never enter _wait_for_all_nics_ready() in any other condition than a fresh source instance in Savable PPS, we can safely remove the now-unused code paths. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
TheRealFalcon
approved these changes
Feb 17, 2022
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
If the VM is rebooted during provisioning, the PPS type will be determined to be UNKNOWN and will poll for reprovision data. Given that we will never enter _wait_for_all_nics_ready() in any other condition than a fresh source instance in Savable PPS, we can safely remove the now-unused code paths. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
If the VM is rebooted during provisioning, the PPS type will be determined to be UNKNOWN and will poll for reprovision data. Given that we will never enter _wait_for_all_nics_ready() in any other condition than a fresh source instance in Savable PPS, we can safely remove the now-unused code paths. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
blackboxsw
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
If the VM is rebooted during provisioning, the PPS type will be determined to be UNKNOWN and will poll for reprovision data. Given that we will never enter _wait_for_all_nics_ready() in any other condition than a fresh source instance in Savable PPS, we can safely remove the now-unused code paths. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the VM is rebooted during provisioning, the PPS type will be
determined to be UNKNOWN and will poll for reprovision data.
Given that we will never enter _wait_for_all_nics_ready() in any
other condition than a fresh source instance in Savable PPS, we can
safely remove the now-unused code paths.
Signed-off-by: Chris Patterson cpatterson@microsoft.com