net/dhcp: surface type of DHCP lease failure to caller#1276
Merged
Conversation
cjp256
changed the title
cjp256
force-pushed
the
net-dhcp-errors
branch
from
048858e to
392256f
Compare
cjp256
force-pushed
the
net-dhcp-errors
branch
from
f229c33 to
71a0b4a
Compare
When performing DHCP, it is useful for the caller to have context on the type of failure. This can be done with some new exceptions types, subclassing NoDHCPLeaseError so the caller's current contract remains. - Add the following errors: - NoDHCPLeaseInterfaceError if there are problems finding the (possibly specified) interface. - NoDHCPLeaseMissingDhclientError for missing dhclient. - Update InvalidDHCPLeaseFileError to subclass NoDHCPLeaseError. - Pass through these errors rather than catching it in obtain_lease(). Tests: - Add missing mock for test_provided_nic_does_not_exist(). - Add new test coverage for EphemeralDHCPv4 errors. - Update existing tests for maybe_perform_dhcp_discovery() to match new behavior. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
net-dhcp-errors
branch
from
71a0b4a to
3ff90cd
Compare
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing DHCP, it is useful for the caller to have context
on the type of failure. This can be done with some new exceptions
types, subclassing NoDHCPLeaseError so the caller's current
contract remains.
Add the following errors:
NoDHCPLeaseInterfaceError if there are problems finding
the (possibly specified) interface.
NoDHCPLeaseMissingDhclientError for missing dhclient.
Update InvalidDHCPLeaseFileError to subclass NoDHCPLeaseError.
Pass through these errors rather than catching it in obtain_lease().
Tests:
Add missing mock for test_provided_nic_does_not_exist().
Add new test coverage for EphemeralDHCPv4 errors.
Update existing tests for maybe_perform_dhcp_discovery() to match
new behavior.
Signed-off-by: Chris Patterson cpatterson@microsoft.com