Clean up artifacts from pytest, packaging, release with make clean#1277
Merged
Conversation
blackboxsw
reviewed
Feb 17, 2022
TheRealFalcon
approved these changes
Feb 17, 2022
blackboxsw
approved these changes
Feb 18, 2022
Collaborator
blackboxsw
left a comment
There was a problem hiding this comment.
LGTM thanks for dropping the debian subdir removal
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
blackboxsw
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like my dev directory has acquired some cruft that
make cleandoesn't currently clean. Some is pytest related, some packaging related, some release related. The.gitignorefile currently masks some of this from git, some it doesn't. Clean it all.Examples[1]:
Note: It appears that
debian/rulescallsmake check, which does not invoke thecleantarget, so this shouldn't change our packaging. I didn't see any other instances ofmakebeing called programmatically, so unless I missed something, this should just be a user-invoked dev tool change.Tested locally.
[1] list of all "untracked" when .gitignore is deleted