Skip to content

Clean up artifacts from pytest, packaging, release with make clean#1277

Merged
blackboxsw merged 2 commits into
canonical:mainfrom
holmanb:holmanb/make-clean
Feb 18, 2022
Merged

Clean up artifacts from pytest, packaging, release with make clean#1277
blackboxsw merged 2 commits into
canonical:mainfrom
holmanb:holmanb/make-clean

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Feb 17, 2022

Clean up artifacts from pytest, packaging, release with make clean

It looks like my dev directory has acquired some cruft that make clean doesn't currently clean. Some is pytest related, some packaging related, some release related. The .gitignore file currently masks some of this from git, some it doesn't. Clean it all.

Examples[1]:

	cloud-init-21.4-130-gf19ca12d.tar.gz
	cloud-init-21.4-130-gf19ca12d.tar.gz.asc
	cloud-init-22.1.tar.gz
	cloud-init-22.1.tar.gz.asc
	cloud-init.dsc
	cloud-init_22.1-0-gf19ca12d-1~bddeb.debian.tar.xz
	cloud-init_22.1-0-gf19ca12d-1~bddeb.dsc
	cloud-init_22.1-0-gf19ca12d-1~bddeb_source.build
	cloud-init_22.1-0-gf19ca12d-1~bddeb_source.buildinfo
	cloud-init_22.1-0-gf19ca12d-1~bddeb_source.changes
	cloud-init_22.1-0-gf19ca12d-1~bddeb~18.04.1.debian.tar.xz
	cloud-init_22.1-0-gf19ca12d-1~bddeb~18.04.1.dsc
	cloud-init_22.1-0-gf19ca12d-1~bddeb~18.04.1_source.build
	cloud-init_22.1-0-gf19ca12d-1~bddeb~18.04.1_source.buildinfo
	cloud-init_22.1-0-gf19ca12d-1~bddeb~18.04.1_source.changes
	cloud-init_22.1-0-gf19ca12d.orig.tar.gz
	cloud_init.egg-info/
	commit.msg
	debian/
	new-upstream-changes.txt
	srpm/
	tags

Note: It appears that debian/rules calls make check, which does not invoke the clean target, so this shouldn't change our packaging. I didn't see any other instances of make being called programmatically, so unless I missed something, this should just be a user-invoked dev tool change.

Tested locally.

[1] list of all "untracked" when .gitignore is deleted

Comment thread Makefile Outdated
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for dropping the debian subdir removal

@blackboxsw blackboxsw merged commit 8999978 into canonical:main Feb 18, 2022
holmanb added a commit to holmanb/cloud-init that referenced this pull request Feb 25, 2022
holmanb added a commit to holmanb/cloud-init that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants