Skip to content

tests: on AWS proper, cloud-id actually starts with aws not ec2#1289

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-cloud-id-aws
Feb 23, 2022
Merged

tests: on AWS proper, cloud-id actually starts with aws not ec2#1289
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-cloud-id-aws

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw commented Feb 21, 2022

Proposed Commit Message

tests: on AWS proper, cloud-id actually starts with aws not ec2

Other clouds such as aliyun, brightbox, e24cloud and zstack
which have EC2-like metadata services will not return "aws"
from cloud-id.

Example AWS instance data:
  $ cloud-init query --format '{{platform}} {{cloud_id}}'
  ec2 aws

Additional Context

Test Steps

CLOUD_INIT_CLOUD_INIT_SOURCE=ppa:cloud-init-dev/daily CLOUD_INIT_PLATFORM=ec2  tox -e integration-tests  tests/integration_tests/modules/test_combined.py::TestCombined::test_instance_json_ec2

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@blackboxsw blackboxsw requested a review from holmanb February 21, 2022 21:28
@blackboxsw blackboxsw changed the title tests: on official AWS, cloud-id actually starts with aws not ec2 tests: on AWS proper, cloud-id actually starts with aws not ec2 Feb 21, 2022
Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Tested and checks out.

@TheRealFalcon TheRealFalcon merged commit fef3428 into canonical:main Feb 23, 2022
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 25, 2022
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 25, 2022
blackboxsw added a commit to holmanb/cloud-init that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants