test_ppa_source: accept both http and https URLs (SC-825)#1292
Merged
Conversation
software-properties 0.99.18 now adds PPAs with HTTPS URLs in sources.list when using add-apt-repository. This change only affects Jammy. We could use a regexp to match both, but it's simpler to just remove the protocol from the search string.
paride
changed the title
blackboxsw
approved these changes
Feb 22, 2022
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
software-properties 0.99.18 now adds PPAs with HTTPS URLs in sources.list when using add-apt-repository. This change only affects Jammy. We could use a regexp to match both, but it's simpler to just remove the protocol from the search string.
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
software-properties 0.99.18 now adds PPAs with HTTPS URLs in sources.list when using add-apt-repository. This change only affects Jammy. We could use a regexp to match both, but it's simpler to just remove the protocol from the search string.
blackboxsw
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 25, 2022
software-properties 0.99.18 now adds PPAs with HTTPS URLs in sources.list when using add-apt-repository. This change only affects Jammy. We could use a regexp to match both, but it's simpler to just remove the protocol from the search string.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
software-properties 0.99.18 now adds PPAs with HTTPS URLs in
sources.list when using add-apt-repository. This change only
affects Jammy.
We could use a regexp to match both, but it's simpler to just remove
the protocol from the search string.
Proposed Commit Message
Additional Context
Spotted by Jenkins.
Test Steps
Run the test against on Jammy.
Checklist: