Better interface handling for Vultr, expect unexpected DHCP servers#1297
Merged
Conversation
000e072 to
611a275
Compare
611a275 to
5dee026
Compare
TheRealFalcon
approved these changes
Mar 4, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good with an inline question and nit.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Better interface handling for Vultr, expect unexpected DHCP servers
Additional Context
The complexity here is due to the wild inconsistency on the platform. An image may end up on a vm, or a baremetal server, or not even be made by us. Options to handle this has been limited. New unittests were added to keep this in check as well.
Test Steps
Deploy a server with a private interface with a dhcp server running on the private network.
Checklist: