Skip to content

Better interface handling for Vultr, expect unexpected DHCP servers#1297

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
eb3095:vultr-nightly
Mar 7, 2022
Merged

Better interface handling for Vultr, expect unexpected DHCP servers#1297
TheRealFalcon merged 2 commits into
canonical:mainfrom
eb3095:vultr-nightly

Conversation

@eb3095
Copy link
Copy Markdown
Contributor

@eb3095 eb3095 commented Feb 23, 2022

Proposed Commit Message

Better interface handling for Vultr, expect unexpected DHCP servers

If a private interface is configured, has a DHCP server on it, and Cloud-Init runs, the Datasource fails to fail over to the next interface interrupting seeking. Configuring it as such can also lead to delays in deploy time if it did. This sorts the interface list to limit the potential of this occurring. Checks for the metadata route before trying, and now appropriately fails over if those contingencies fails by appropriately continuing to seek on metadata failure as was originally intended. Ideally the upcoming candidate_nic would of been used here to avoid the interface list function.

Additional Context

The complexity here is due to the wild inconsistency on the platform. An image may end up on a vm, or a baremetal server, or not even be made by us. Options to handle this has been limited. New unittests were added to keep this in check as well.

Test Steps

Deploy a server with a private interface with a dhcp server running on the private network.

Checklist:

  • [ X ] My code follows the process laid out in the documentation
  • [ X ] I have updated or added any unit tests accordingly
  • [ X ] I have updated or added any documentation accordingly

@eb3095 eb3095 force-pushed the vultr-nightly branch 8 times, most recently from 000e072 to 611a275 Compare February 24, 2022 18:49
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with an inline question and nit.

Comment thread cloudinit/sources/helpers/vultr.py Outdated
Comment thread cloudinit/sources/helpers/vultr.py Outdated
@TheRealFalcon TheRealFalcon merged commit 4f1f591 into canonical:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants