Skip to content

Make VMWare data source test host independent and expand testing #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealFalcon merged 3 commits into from
Mar 9, 2022
Merged

Make VMWare data source test host independent and expand testing #1308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68614a7
Make VMWare data source test host independent and expand testing
rjschwei Feb 26, 2022
46f5d23
Fix formatting error
rjschwei Feb 28, 2022
df77d97
Move some patches into fixture
TheRealFalcon Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 55 additions & 5 deletions tests/unittests/sources/test_vmware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import base64
import gzip
import os
from contextlib import ExitStack

import pytest

Expand Down Expand Up @@ -59,13 +60,26 @@

@pytest.fixture(autouse=True)
def common_patches():
with mock.patch("cloudinit.util.platform.platform", return_value="Linux"):
with mock.patch.multiple(
mocks = [
mock.patch("cloudinit.util.platform.platform", return_value="Linux"),
mock.patch.multiple(
"cloudinit.dmi",
is_container=mock.Mock(return_value=False),
is_FreeBSD=mock.Mock(return_value=False),
):
yield
),
mock.patch(
"cloudinit.sources.DataSourceVMware.netifaces.interfaces",
return_value=[],
),
mock.patch(
"cloudinit.sources.DataSourceVMware.getfqdn",
return_value="host.cloudinit.test",
),
]
with ExitStack() as stack:
for some_mock in mocks:
stack.enter_context(some_mock)
yield


class TestDataSourceVMware(CiTestCase):
Expand All @@ -83,13 +97,49 @@ def test_no_data_access_method(self):
ret = ds.get_data()
self.assertFalse(ret)

def test_get_host_info(self):
@mock.patch("cloudinit.sources.DataSourceVMware.get_default_ip_addrs")
def test_get_host_info_ipv4(self, m_fn_ipaddr):
m_fn_ipaddr.return_value = ("10.10.10.1", None)
host_info = DataSourceVMware.get_host_info()
self.assertTrue(host_info)
self.assertTrue(host_info["hostname"])
self.assertTrue(host_info["hostname"] == "host.cloudinit.test")
self.assertTrue(host_info["local-hostname"])
self.assertTrue(host_info["local_hostname"])
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV4])
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV4] == "10.10.10.1")
self.assertFalse(host_info.get(DataSourceVMware.LOCAL_IPV6))

@mock.patch("cloudinit.sources.DataSourceVMware.get_default_ip_addrs")
def test_get_host_info_ipv6(self, m_fn_ipaddr):
m_fn_ipaddr.return_value = (None, "2001:db8::::::8888")
host_info = DataSourceVMware.get_host_info()
self.assertTrue(host_info)
self.assertTrue(host_info["hostname"])
self.assertTrue(host_info["hostname"] == "host.cloudinit.test")
self.assertTrue(host_info["local-hostname"])
self.assertTrue(host_info["local_hostname"])
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV6])
self.assertTrue(
host_info[DataSourceVMware.LOCAL_IPV6] == "2001:db8::::::8888"
)
self.assertFalse(host_info.get(DataSourceVMware.LOCAL_IPV4))

@mock.patch("cloudinit.sources.DataSourceVMware.get_default_ip_addrs")
def test_get_host_info_dual(self, m_fn_ipaddr):
m_fn_ipaddr.return_value = ("10.10.10.1", "2001:db8::::::8888")
host_info = DataSourceVMware.get_host_info()
self.assertTrue(host_info)
self.assertTrue(host_info["hostname"])
self.assertTrue(host_info["hostname"] == "host.cloudinit.test")
self.assertTrue(host_info["local-hostname"])
self.assertTrue(host_info["local_hostname"])
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV4])
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV4] == "10.10.10.1")
self.assertTrue(host_info[DataSourceVMware.LOCAL_IPV6])
self.assertTrue(
host_info[DataSourceVMware.LOCAL_IPV6] == "2001:db8::::::8888"
)


class TestDataSourceVMwareEnvVars(FilesystemMockingTestCase):
Expand Down