add support for jinja do statements, add unit test#1314
Merged
Conversation
blackboxsw
reviewed
Mar 2, 2022
Collaborator
blackboxsw
left a comment
There was a problem hiding this comment.
Thanks for the bug and quick PR @thetoolsmith. I'll await confirmation on the CLA signing
which should become available to me tomorrow.
Confirmed "do" extension is present and functions properly without error on Ubuntu Bionic 18.04 (python3-jinja2 v. 2.10) and later.
Simple test with this changset generates the updated list output without printing the None return value from the append function call"
$ cloud-init query --format "{% set r = [] %}{% set input = [1,2,3] %}{% for i in input %}{% do r.append(i) %}{% endfor %}{{r}}"
[1, 2, 3]
blackboxsw
approved these changes
Mar 3, 2022
Collaborator
blackboxsw
left a comment
There was a problem hiding this comment.
I confirm @thetoolsmith has signed the Contributor License Agreement for cloud-init, welcome to the project and thanks for your submission.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Adding support for jinja do statements in template rendering.
Additional Context
Test Steps
When processing the following example, the jinja exception is thrown.
{% set data_result = [] %}
{% set data_input = [1,2,3] %}
{% for i in data_input %}
{% do data_result.append(i) %}
{% endfor %}
{{data_result}}
Checklist: