remove flaky test from ci (SC-850)#1322
Merged
Merged
Conversation
6683356 to
92770c5
Compare
TheRealFalcon
approved these changes
Mar 8, 2022
Contributor
There was a problem hiding this comment.
LGTM assuming tests pass.
Long term, I think it's worth seeing if ssh-import-id can give us any meaningful response other than failure. If it fails because one of the services are down, we can just skip the test for that run. If not, this is probably better replaced with a unit test.
cjp256
approved these changes
Mar 8, 2022
Member
Author
Based on a quick glance at the source, it looks like return codes are hardcoded at 0 and 1, but in the case of failure (rc=1) it prints out error messages we could use. |
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Context
Here is an example flaky failure:
#1302 (comment)
This same failure has happened to me as well.