Skip to content

remove flaky test from ci (SC-850)#1322

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
holmanb:holmanb/flaky-test
Mar 8, 2022
Merged

remove flaky test from ci (SC-850)#1322
TheRealFalcon merged 1 commit into
canonical:mainfrom
holmanb:holmanb/flaky-test

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Mar 8, 2022

Remove flaky test

This ssh-import-id test uses multiple remote key servers
that fail periodically.

Additional Context

Here is an example flaky failure:
#1302 (comment)

This same failure has happened to me as well.

@holmanb holmanb force-pushed the holmanb/flaky-test branch from 6683356 to 92770c5 Compare March 8, 2022 14:31
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

Long term, I think it's worth seeing if ssh-import-id can give us any meaningful response other than failure. If it fails because one of the services are down, we can just skip the test for that run. If not, this is probably better replaced with a unit test.

@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Mar 8, 2022

Long term, I think it's worth seeing if ssh-import-id can give us any meaningful response other than failure.

Based on a quick glance at the source, it looks like return codes are hardcoded at 0 and 1, but in the case of failure (rc=1) it prints out error messages we could use.

@holmanb holmanb changed the title remove flaky test from ci remove flaky test from ci (SC-850) Mar 8, 2022
@TheRealFalcon TheRealFalcon merged commit 9f73454 into canonical:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants