Skip to content

Revert "Ensure system_cfg read before ds net config on Oracle (#1174)"#1326

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:revert-oracle
Mar 11, 2022
Merged

Revert "Ensure system_cfg read before ds net config on Oracle (#1174)"#1326
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:revert-oracle

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon commented Mar 10, 2022

Proposed Commit Message

This reverts commit b306633fd17e5ba0173ad3c41add59cb11884757.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.

Additional Context

#1174
https://bugs.launchpad.net/cloud-init/+bug/1956788

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

…cal#1174)"

This reverts commit b306633.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.
@TheRealFalcon TheRealFalcon added the wip Work in progress, do not land label Mar 10, 2022
@TheRealFalcon
Copy link
Copy Markdown
Contributor Author

@smoser or @OddBloke , do either of you have any context as to why Oracle images have the file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg, whose contents disable networking? The ordering of network_config_sources made it so that this file hasn't been respected anyway. I'm curious if we can request that this file be removed.

@TheRealFalcon TheRealFalcon removed the wip Work in progress, do not land label Mar 11, 2022
@TheRealFalcon
Copy link
Copy Markdown
Contributor Author

I built a deb and tested that tests/integration_tests/modules/test_combined.py runs successfully. Without this revert, we would not be able to connect to the instance.

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM revert is clean revert here to what was already released and functional on Oracle.

@blackboxsw blackboxsw merged commit 5e347d2 into canonical:main Mar 11, 2022
TheRealFalcon added a commit that referenced this pull request Mar 11, 2022
#1326)

This reverts commit b306633.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.
TheRealFalcon added a commit that referenced this pull request Mar 11, 2022
#1326)

This reverts commit b306633.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.
TheRealFalcon added a commit that referenced this pull request Mar 11, 2022
#1326)

This reverts commit b306633.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.
TheRealFalcon added a commit that referenced this pull request Mar 11, 2022
#1326)

This reverts commit b306633.

While this ultimately seems like a better solution, currently the
file /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg exists on
all Oracle launched instances which will prevent networking from
being properly initialized.
@TheRealFalcon TheRealFalcon deleted the revert-oracle branch May 17, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants