Skip to content

sources/azure: remove bind/unbind logic for hot attached nic#1332

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
cjp256:azure-no-unbind
Apr 4, 2022
Merged

sources/azure: remove bind/unbind logic for hot attached nic#1332
TheRealFalcon merged 1 commit into
canonical:mainfrom
cjp256:azure-no-unbind

Conversation

@cjp256
Copy link
Copy Markdown
Contributor

@cjp256 cjp256 commented Mar 14, 2022

Wait up to 10 seconds for link to come up before continuing. This
typically takes just a few seconds once the NIC is hotplugged.

If it takes longer than 10 seconds for whatever reason, dhclient
should eventually succeed on its next attempt after the link does
come online.

Signed-off-by: Chris Patterson cpatterson@microsoft.com

@github-actions
Copy link
Copy Markdown

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions Bot added the stale-pr Pull request is stale; will be auto-closed soon label Mar 29, 2022
@TheRealFalcon
Copy link
Copy Markdown
Contributor

@cjp256 I haven't reviewed this because of the draft state. If it's ready for review, let me know and I can review it.

@cjp256 cjp256 marked this pull request as ready for review March 31, 2022 13:39
@cjp256
Copy link
Copy Markdown
Contributor Author

cjp256 commented Mar 31, 2022

Thanks James, given the nature of this change I've just had it in testing for quite some time :D Opened for review.

Wait up to 10 seconds for link to come up before continuing. This
typically takes just a few seconds once the NIC is hotplugged.

If it takes longer than 10 seconds for whatever reason, dhclient
should eventually succeed on its next attempt after the link does
come online.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Copy link
Copy Markdown
Contributor

@anhvoms anhvoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit b51134b into canonical:main Apr 4, 2022
@cjp256 cjp256 deleted the azure-no-unbind branch April 25, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale-pr Pull request is stale; will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants