Skip to content

add Requires=cloud-init-hotplugd.socket in cloud-init-hotplugd.servic…#1335

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
yangzz-97:main
Mar 17, 2022
Merged

add Requires=cloud-init-hotplugd.socket in cloud-init-hotplugd.servic…#1335
TheRealFalcon merged 1 commit into
canonical:mainfrom
yangzz-97:main

Conversation

@yangzz-97
Copy link
Copy Markdown
Contributor

If we start the service directly, it should pull up the socket through Requires
#1331 (comment)

…e file

Signed-off-by: yangzz-97 <yangzz-97@1162011203@qq.com>
@TheRealFalcon
Copy link
Copy Markdown
Contributor

@yangzz-97 so you no longer agree with #1331 (comment) ? How are you sure that the socket will exist first?

Also, I noticed you added yourself to the CLA signers file, but have you signed the actual CLA too? I'm not seeing your information there. If you did, can you provide the date that you signed it?

@yangzz-97
Copy link
Copy Markdown
Contributor Author

@TheRealFalcon I'm sorry for the trouble.
I agree with #1331 (comment)
I just think that if I don't know the relationship between socket and service, directly starting the service will make an error, causing users to have questions, so I wonder if I can add requirements to ensure that the socket is automatically pulled up when starting the service. At the same time, the after option already exists to ensure that the service is started after the socket.

I can't click the "I agree" button on the cla page,I don't know why

@yangzz-97
Copy link
Copy Markdown
Contributor Author

Do you think it needs to be modified like this?

@TheRealFalcon
Copy link
Copy Markdown
Contributor

I see, sorry, I misunderstood your comment. The code as-is looks good.

I can't click the "I agree" button on the cla page,I don't know why

There's a CAPTCHA below the form but above the 'I agree' button. Once that is verified, the button should be clickable.

@yangzz-97
Copy link
Copy Markdown
Contributor Author

yangzz-97 commented Mar 15, 2022

don't have CAPTCHA
you see
image

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Strange...are you running any sort of ad or script blocker? Is it possible to try another browser?
image

Another option is to sign the pdf and send it to contributor-agreement@canonical.com

@yangzz-97
Copy link
Copy Markdown
Contributor Author

yangzz-97 commented Mar 16, 2022

@TheRealFalcon ok,I have signed the pdf and send it to contributor-agreement@canonical.com

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants