Refactoring helper funcs out of NetworkState#1336
Merged
Merged
Conversation
3 tasks
Contributor
Author
|
Oh fun, I suppose I need to actually run all the unit tests locally to find what I broke 😃 |
28b37bc to
77d9b8a
Compare
This patch refactors several network, helper functions out of the network_state.py file and into cloudinit.net. This is in relation to LP #1855945 and github.com/canonical/pull/1327. The aforementioned issue requires some refactoring to avoid circular imports, but it was not proper to do that refactoring in *that* pull request. Thus this PR is specific to the refactoring and can be evaluated on its own merits.
77d9b8a to
245980d
Compare
TheRealFalcon
approved these changes
Mar 15, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thanks for this! To be clear, when I mentioned that ideally we'd move those functions, I wasn't expecting you to do it...but I appreciate it 🙂
Contributor
Author
Well, I mean someone was going to end up doing it. Why not me? 😄 |
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
cc @TheRealFalcon
Additional Context
Please see #1327 and #1327 (comment) for more information.
Test Steps
I also ran this, and the only failing tests were because I was on a mac:
Checklist: