Skip to content

Add --no-update to add-apt-repostory call (SC-880)#1337

Merged
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:apt-no-update
Mar 28, 2022
Merged

Add --no-update to add-apt-repostory call (SC-880)#1337
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:apt-no-update

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Proposed Commit Message

Add --no-update to add-apt-repostory call

In cc_apt_configure, "add-apt-repository" is called a few lines before
we make a call to update packages, so the additional update that
happens in "add-apt-repository" is redundant and a waste of time.
Additionally, the update in add-apt-repository can fail on
obtaining apt lock and cause the module to raise an exception.

In cc_apt_configure, "add-apt-repository" is called a few lines before
we make a call to update packages, so the additional update that
happens in "add-apt-repository" is redundant and a waste of time.
Additionally, the update in add-apt-repository can fail on
obtaining apt lock and cause the module to raise an exception.
Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon changed the title Add --no-update to add-apt-repostory call Add --no-update to add-apt-repostory call (SC-880) Mar 24, 2022
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackboxsw blackboxsw merged commit 1ef87e6 into canonical:main Mar 28, 2022
@TheRealFalcon TheRealFalcon deleted the apt-no-update branch March 21, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants