testing: Add missing mock to networking test#1353
Merged
Merged
Conversation
TheRealFalcon
force-pushed
the
test-mock2
branch
from
02ea14c to
b757faf
Compare
blackboxsw
requested changes
Mar 28, 2022
| @mock.patch("cloudinit.net.get_interfaces_by_mac") | ||
| @mock.patch("cloudinit.subp.subp") | ||
| def test_render_output_has_yaml(self, mock_subp): | ||
| def test_render_output_has_yaml(self, m_get_interfaces, m_subp): |
Collaborator
There was a problem hiding this comment.
Should this instead be the following diff? If not, minimally the order of the mocked params should switch
diff --git a/tests/unittests/test_net_freebsd.py b/tests/unittests/test_net_freebsd.py
index 3facb2bb4..bf850ceaf 100644
--- a/tests/unittests/test_net_freebsd.py
+++ b/tests/unittests/test_net_freebsd.py
@@ -61,8 +61,10 @@ class TestFreeBSDRoundTrip(CiTestCase):
return dir2dict(target)
@mock.patch("cloudinit.subp.subp")
- def test_render_output_has_yaml(self, mock_subp):
+ @mock.patch("cloudinit.util.is_FreeBSD", return_value=True)
+ def test_render_output_has_yaml(self, _is_freebsd, mock_subp):
+ mock_subp.return_value = (SAMPLE_FREEBSD_IFCONFIG_OUT, 0)
entry = {
"yaml": V1,
}
Contributor
Author
There was a problem hiding this comment.
Yes, this is better
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is failing for me locally (but not in CI)