The devname referenced in your traceback should be the result of get_devicelist(), which should be mocked.

[yangzz-97]

Hello
I am executing the cloud-init test case and the testcase has occasionally failed.
The failure testcases are:
FAILED tests/unittests/test_net.py::TestGetInterfaces::test_gi_excludes_any_without_mac_address
FAILED tests/unittests/test_net.py::TestGetInterfaces::test_gi_excludes_stolen_macs
FAILED tests/unittests/test_net.py::TestGetInterfaces::test_gi_includes_duplicate_macs

The error log for each failed use case is similar as follows:

    def test_gi_excludes_any_without_mac_address(self):
        self._mock_setup()
>       ret = net.get_interfaces()

tests/unittests/test_net.py:5431:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
cloudinit/net/__init__.py:941: in get_interfaces
    if is_netfailover(name):
cloudinit/net/__init__.py:204: in is_netfailover
    if is_netfail_primary(devname, driver) or is_netfail_standby(devname,
cloudinit/net/__init__.py:279: in is_netfail_primary
    master_driver = device_driver(master_devname)
/usr/lib64/python3.9/unittest/mock.py:1092: in __call__
    return self._mock_call(*args, **kwargs)
/usr/lib64/python3.9/unittest/mock.py:1096: in _mock_call
    return self._execute_mock_call(*args, **kwargs)
/usr/lib64/python3.9/unittest/mock.py:1157: in _execute_mock_call
    result = effect(*args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <tests.unittests.test_net.TestGetInterfaces testMethod=test_gi_excludes_any_without_mac_address>
name = 'bond0'

    def _se_device_driver(self, name):
>       return self.data['drivers'][name]
E       KeyError: 'bond0'

tests/unittests/test_net.py:5390: KeyError

Note: The file line number in the preceding log information may not match the latest code.

When the test case fails, the bond0 network adapter exists in my environment. 

According to the error log "KeyError: 'bond0'", I think that the data dictionary defined in the test case does not contain the bond keyword.

SO，I tried to add the bond0 keyword to the data dictionary. The test case was successfully executed.
Please help me to check whether the modification is feasible. Thank you.

[TheRealFalcon]

@yangzz-97 , I'm not exactly sure what's going on. The devname referenced in your traceback should be the result of get_devicelist(), which should be mocked.

I think there might be a bigger mocking issue that your change doesn't address.

Does a patch like this work for you?

diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py
index fa8b99a0..6844c329 100644
--- a/tests/unittests/test_net.py
+++ b/tests/unittests/test_net.py
@@ -7454,6 +7454,12 @@ class TestGetInterfaces(CiTestCase):
     def _se_interface_has_own_mac(self, name):
         return name in self.data["own_macs"]
 
+    def _se_is_bond(self, name):
+        return name in self.data["bonds"]
+
+    def _se_is_netfailover(self, name):
+        return False
+
     def _mock_setup(self):
         self.data = copy.deepcopy(self._data)
         self.data["devices"] = set(list(self.data["macs"].keys()))
@@ -7465,6 +7471,8 @@ class TestGetInterfaces(CiTestCase):
             "is_vlan",
             "device_driver",
             "device_devid",
+            "is_bond",
+            "is_netfailover",
         )
         self.mocks = {}
         for n in mocks:

[yangzz-97]

@TheRealFalcon
Thank you very much! This patch works for me.I have resubmitted it

[yangzz-97]

Maybe I didn't do it right and made a lot of commits

[TheRealFalcon]

Thanks!