Skip to content

black: bump pinned version to 22.3.0 to avoid click dependency issues#1357

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:pinning-black-fmt
Mar 29, 2022
Merged

black: bump pinned version to 22.3.0 to avoid click dependency issues#1357
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:pinning-black-fmt

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

Proposed Commit Message

Black < 22.3.0 didn't handle a dropped internal attribute _unicodefun
 from in more click package version 8.1.0. Due to issue
    Issue: https://github.com/psf/black/issues/2964

This broke our CI and tox -e do_format targets with
   cannot import name '_unicodefun' from 'click'.

Increment our pinned black to 22.3.0 and apply minor format
change rules.

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Black < 22.3.0 didn't handle a dropped internal attribute _unicodefun
 from in more click package version 8.1.0. Due to issue
    Issue: psf/black#2964

This broke our CI and tox -e do_format targets with
   cannot import name '_unicodefun' from 'click'.

Increment our pinned black to 22.3.0 and apply minor format
change rules.
@blackboxsw blackboxsw requested a review from holmanb March 29, 2022 19:14
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon merged commit 9f1876d into canonical:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants