schema: add JSON schema for mcollective, migrator and mounts modules #1358
Merged
Conversation
d95b523 to
2aa230f
Compare
TheRealFalcon
suggested changes
Mar 30, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
Some comments inline, but overall looking good.
| }, | ||
| "size": { | ||
| "description": "The size in bytes of the swap file, or 'auto'", | ||
| "oneOf": [{"enum": ["auto"]}, {"type": "integer"}] |
Contributor
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
whoa nice find will add a positive example here in meta schema and fix this.
Collaborator
Author
There was a problem hiding this comment.
added "pattern": "^([0-9]+)?\\.?[0-9]+[BKMGT]$"} to schema for swap.size swap.maxsize and unittests
TheRealFalcon
suggested changes
Mar 30, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
One typo we should fix, and everything else optional. For some reason Github wouldn't let me do suggestions on this review.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Unit tests will run through any included cc_.meta['examples'] to confirm that they are correct schema.
Checklist: