Skip to content

sources/azure: only wait for primary nic to be attached during restore#1378

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
anhvoms:anhvo/skipSecondaryNics
Apr 18, 2022
Merged

sources/azure: only wait for primary nic to be attached during restore#1378
TheRealFalcon merged 2 commits into
canonical:mainfrom
anhvoms:anhvo/skipSecondaryNics

Conversation

@anhvoms
Copy link
Copy Markdown
Contributor

@anhvoms anhvoms commented Apr 13, 2022

Proposed Commit Message

sources/azure: only wait for primary nic to be attached during restore

summary:
Currently DS Azure waits for all nics to be up and running during the 
restore phase of save-restore VMs. This change will alter the behavior
so that it will only wait for primary nic. This new behavior is consistent
with non-preprovisioning and running types.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Comment thread tests/unittests/sources/test_azure.py Outdated
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you plan on addressing the mock comment?

@anhvoms
Copy link
Copy Markdown
Contributor Author

anhvoms commented Apr 18, 2022

LGTM, but do you plan on addressing the mock comment?

Yep - please check latest iteration. Thanks!

@TheRealFalcon TheRealFalcon merged commit e783ef5 into canonical:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants