Network functions refactor and bugfixes#1383
Merged
Merged
Conversation
holmanb
force-pushed
the
holmanb/network-refactor
branch
from
b00bdc2 to
226a066
Compare
holmanb
commented
Apr 15, 2022
| addr_part, _, maybe_prefix = addr.partition("/") | ||
| net[addr_key] = addr_part | ||
| try: | ||
| prefix = int(maybe_prefix) |
Member
Author
There was a problem hiding this comment.
Note this try/except was redundant: ipv{4,6}_mask_to_net_prefix() can handle an argument already in prefix form.
- replace common functionality with standard library implementations - add is_ip_network() for validating addresses in form: "192.168.1.1/24" - add validation to _normalize_net_keys - fix eni tests that formerly tested invalid ipv6 addresses (caught by stricter validation) - other refactorization and name standardization
holmanb
force-pushed
the
holmanb/network-refactor
branch
from
226a066 to
7d7ff5f
Compare
TheRealFalcon
approved these changes
Apr 15, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Nice refactoring, thanks! One spelling error inline, but I trust you can fix that without needing a re-review. Now just waiting for the https://xkcd.com/1172/ bugs.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing is_ipv6_addr() broke a lot of tests, which demonstrated that it was implemented incorrectly and used incorrectly.