Skip to content

cc_ntp: migrated legacy schema to cloud-init-schema.json#1384

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:schema-migrate-ntp
Apr 15, 2022
Merged

cc_ntp: migrated legacy schema to cloud-init-schema.json#1384
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:schema-migrate-ntp

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw commented Apr 15, 2022 •
edited
Loading

Fixes: SC-803

Proposed commit message

cc_ntp: migrated legacy schema to cloud-init-schema.json

Fixes: SC-803

Additional Context

Test Steps

# ensure docs didn't change or unittests fail as a result of this PR
git checkout main
PYTHONPATH=. python3 -m cloudinit.cmd.main devel schema --docs all > docs.main
hub pr checkout 1384
PYTHONPATH=. python3 -m cloudinit.cmd.main devel schema --docs all > docs.PR
diff -urN docs.main docs.PR

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

TheRealFalcon
TheRealFalcon approved these changes Apr 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last (documented) module! 🎉

Comment thread tests/unittests/config/test_schema.py
] == sorted(legacy_schema_keys)
# This list should remain empty unless we induct new modules with
# legacy schema attributes defined within the cc_module.
assert [] == sorted(legacy_schema_keys)
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo!!!

@TheRealFalcon TheRealFalcon merged commit f442327 into canonical:main Apr 15, 2022
This was referenced May 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holmanb holmanb Awaiting requested review from holmanb

1 more reviewer

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blackboxsw @TheRealFalcon