cloudinit.net refactor: apply_network_config_names

[aciba90]

Proposed Commit Message

cloudinit.net refactor: apply_network_config_names

- Remove `apply_network_config_names` from `cloudinit.net` and `Distro` classes so it is only accessible via the networking attribute.

LP: #1884602

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[TheRealFalcon]

@aciba90 , thanks for this contribution.

I think the end goal of the net refactor (which has admittedly stalled), is to remove methods from the distro classes entirely and into the networking classes. So the call in stages.py would be self.distro.networking.apply_network_config_names(netcfg) instead.

In order to do that, we would also need implementations in the BSD networking class. The current implementations (e.g., 1 2 3 ) are unsupported or no-ops and would also need to be refactored into this networking class setup.

[aciba90]

Thank you for your comments.

I think the end goal of the net refactor (which has admittedly stalled), is to remove methods from the distro classes entirely and into the networking classes. So the call in stages.py would be self.distro.networking.apply_network_config_names(netcfg) instead.

I have removed those methods and made the change in stages.py.

In order to do that, we would also need implementations in the BSD networking class. The current implementations (e.g., 1 2 3 ) are unsupported or no-ops and would also need to be refactored into this networking class setup.

I have moved current implementations into BSDNetworking and FreeBSDNetworking.

@TheRealFalcon please let me know if there is something else to improve.

[TheRealFalcon]

Thanks for addressing the requested changes. One more minor change in where the new networking class lives, and I think we'll be good here.

[TheRealFalcon]

Let's put this class in networking.py. For now, I think it makes more sense there.

[aciba90]

Done

[TheRealFalcon]

Nice refactor of these tests! This is much nicer.

[aciba90]

Thanks!

[TheRealFalcon]

Nit: test_apply_v2_renames_skips_without_setname_or_mac

[aciba90]

Done

[aciba90]

Thanks for addressing the requested changes. One more minor change in where the new networking class lives, and I think we'll be good here.

Thanks for the comments. Resolved!

[TheRealFalcon]

LGTM, thanks! I'm going to briefly close and then reopen this PR to trigger a Travis rebuild.

[TheRealFalcon]

Let's put this class into the networking.py. For now, I think it makes more sense there.