sources/azure: refactor http_with_retries to remove **kwargs#1392
Merged
blackboxsw merged 2 commits intoApr 20, 2022
Merged
Conversation
Remove unused functionality and general kwargs support in favor of defined parameters. As only headers and data kwargs are used, add those explicitly to http_with_retries(). There should be no behavioral changes. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
blackboxsw
reviewed
Apr 19, 2022
| @azure_ds_telemetry_reporter | ||
| def http_with_retries(url, **kwargs) -> url_helper.UrlResponse: | ||
| def http_with_retries( | ||
| url, *, headers: dict, data=None |
Collaborator
There was a problem hiding this comment.
Since we are type hinting, let's get url too
Suggested change
| url, *, headers: dict, data=None | |
| url: str, *, headers: dict, data=None |
Contributor
Author
There was a problem hiding this comment.
done, for data too, thanks!
blackboxsw
reviewed
Apr 19, 2022
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Just a minor nit and +1
cjp256
force-pushed
the
azure-refactor-http-with-retries-kwargs
branch
from
21836ca to
e5706fb
Compare
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused functionality and general kwargs support in favor
of defined parameters.
As only headers and data kwargs are used, add those explicitly
to http_with_retries().
There should be no behavioral changes.
Signed-off-by: Chris Patterson cpatterson@microsoft.com