Skip to content

sources/azure: fix provisioning dhcp timeout to 20 minutes#1394

Merged
holmanb merged 1 commit into
canonical:mainfrom
cjp256:azure-fix-provisioning-dhcp-timeout
Apr 21, 2022
Merged

sources/azure: fix provisioning dhcp timeout to 20 minutes#1394
holmanb merged 1 commit into
canonical:mainfrom
cjp256:azure-fix-provisioning-dhcp-timeout

Conversation

@cjp256
Copy link
Copy Markdown
Contributor

@cjp256 cjp256 commented Apr 20, 2022

While this was a previously intended change, the actual logic was
backwards. Try for 20 minutes during provisioning, only 5 minutes
otherwise.

Add test coverage to verify the timeout for provisioning scenarios.

Signed-off-by: Chris Patterson cpatterson@microsoft.com

While this was a previously intended change, the actual logic was
backwards.  Try for 20 minutes during provisioning, only 5 minutes
otherwise.

Add test coverage to verify the timeout for provisioning scenarios.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Copy link
Copy Markdown
Contributor

@anhvoms anhvoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holmanb holmanb merged commit 913c298 into canonical:main Apr 21, 2022
@cjp256 cjp256 deleted the azure-fix-provisioning-dhcp-timeout branch April 25, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants