Skip to content

Promote cloud-init schema (SC-953)#1402

Merged
holmanb merged 9 commits into
canonical:mainfrom
holmanb:holmanb/cloud-init-schema
Apr 27, 2022
Merged

Promote cloud-init schema (SC-953)#1402
holmanb merged 9 commits into
canonical:mainfrom
holmanb:holmanb/cloud-init-schema

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Apr 25, 2022

Promote schema command from devel to top level subcommand

@holmanb holmanb marked this pull request as ready for review April 25, 2022 22:38
@holmanb holmanb changed the title Promote cloud-init schema Promote cloud-init schema (SC-953) Apr 25, 2022
@holmanb holmanb force-pushed the holmanb/cloud-init-schema branch 2 times, most recently from 756f698 to 91b54a9 Compare April 26, 2022 17:55
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really nice changes here. Normally I like small updates along the way, but it looks like there's more non-schema changes than there are schema ones. Do you mind moving the misc updates to another PR?

Additionally, there's some other places that need to be updated.

  • If you search for "devel schema" in faq.rst, tutorial.rst, and tests/integration_tests/modules/test_cli.py, they all need updates.
  • Search '"devel", "schema"' in tests/unittests/test_cli.py
  • cli.rst has schema documentation under the devel heading.
  • bash_completion/cloud-init has schema is under devel

Comment thread cloudinit/cmd/devel/parser.py Outdated
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Apr 26, 2022

Some really nice changes here. Normally I like small updates along the way, but it looks like there's more non-schema changes than there are schema ones. Do you mind moving the misc updates to another PR?

No problem. Agreed, this is snowballing a bit.

Additionally, there's some other places that need to be updated.

Thanks. I'll fix those as well.

@holmanb holmanb force-pushed the holmanb/cloud-init-schema branch from 91b54a9 to f797254 Compare April 26, 2022 18:44
@holmanb holmanb force-pushed the holmanb/cloud-init-schema branch from f797254 to ffbad71 Compare April 26, 2022 18:58
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Apr 26, 2022

Note: I had to rebase for dropping commits, hence the force push. Since I already had to force push, I squashed the recommended "drop devel schema" change into the promotion commit since they overlapped.

Assuming this CI run passes, I think it should be ready for re-review.

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I trust you can fix the flake8 and spell check issue without another review.

@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Apr 27, 2022

After rerunning CI passes, merging.

@holmanb holmanb merged commit 3bcffac into canonical:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants