Promote cloud-init schema (SC-953)#1402
Conversation
756f698 to
91b54a9
Compare
TheRealFalcon
left a comment
There was a problem hiding this comment.
Some really nice changes here. Normally I like small updates along the way, but it looks like there's more non-schema changes than there are schema ones. Do you mind moving the misc updates to another PR?
Additionally, there's some other places that need to be updated.
- If you search for "devel schema" in faq.rst, tutorial.rst, and tests/integration_tests/modules/test_cli.py, they all need updates.
- Search '"devel", "schema"' in tests/unittests/test_cli.py
- cli.rst has schema documentation under the devel heading.
bash_completion/cloud-inithas schema is under devel
No problem. Agreed, this is snowballing a bit.
Thanks. I'll fix those as well. |
91b54a9 to
f797254
Compare
f797254 to
ffbad71
Compare
|
Note: I had to rebase for dropping commits, hence the force push. Since I already had to force push, I squashed the recommended "drop devel schema" change into the promotion commit since they overlapped. Assuming this CI run passes, I think it should be ready for re-review. |
TheRealFalcon
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I trust you can fix the flake8 and spell check issue without another review.
|
After rerunning CI passes, merging. |
Uh oh!
There was an error while loading. Please reload this page.