Skip to content

Fix cc_rsyslog.py initialization#1404

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
aciba90:SC-878/fix_cc_rsyslog.py_initialization
Apr 27, 2022
Merged

Fix cc_rsyslog.py initialization#1404
TheRealFalcon merged 1 commit into
canonical:mainfrom
aciba90:SC-878/fix_cc_rsyslog.py_initialization

Conversation

@aciba90
Copy link
Copy Markdown
Contributor

@aciba90 aciba90 commented Apr 26, 2022

Proposed Commit Message

Fix cc_rsyslog.py initialization

Raises an error if some top level config value has an invalid type.
Previously, it replaced them with default values.

Fixes: SC-878

Test Steps

Execute cloud-init with this config:

#cloud-config
rsyslog:
  config_dir: True

Expected error:

"Invalid type for key `config_filename`. Expected type(s): <class 'str'>. Current type: <class 'bool'>"

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Raises an error if some top level config value has an invalid
type.
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon merged commit 729545c into canonical:main Apr 27, 2022
@aciba90 aciba90 deleted the SC-878/fix_cc_rsyslog.py_initialization branch April 28, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants