mypy: disable missing imports warning for httpretty#1412
Merged
Conversation
httpretty does not appear to support mypy stubs. Add configuration to for mypy to ignore this import. With this we can add checking for test_azure.py. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
TheRealFalcon
approved these changes
Apr 27, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good assuming CI passes. We're hoping to replace httpretty with responses in the near future due to all the httpretty issues we've had.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpretty does not appear to support mypy stubs. Add configuration
to for mypy to ignore this import.
With this we can add checking for test_azure.py.
Signed-off-by: Chris Patterson cpatterson@microsoft.com