Skip to content

tests: verify_ordered_items fallback to re.escape if needed#1420

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-regex-fix
Apr 29, 2022
Merged

tests: verify_ordered_items fallback to re.escape if needed#1420
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-regex-fix

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

Failures in Jenkins test runner indicate that the recent changes landed in
02f213b didn't account for some search items containing characters which need to be
re.escaped.

Proposed Commit Message

tests: verify_ordered_items fallback to re.escape if needed

When re.search fails with an re.error, it is most likely due
to characters which need escape. Fallback to re.escape in
this case to try harder.

Additional Context

Failing Jenkins job

Test Steps

.tox/integration-tests/bin/pytest tests/integration_tests/bugs/test_lp1813396.py::test_gpg_no_tty

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping get our jenkins house in order!

@TheRealFalcon TheRealFalcon merged commit c55534d into canonical:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants