Fix bug in url_helper/dual_stack() logging#1426
Merged
Merged
Conversation
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good, but probably worth some unit testing checking exception behavior.
holmanb
force-pushed
the
holmanb/url-helper-fix
branch
2 times, most recently
from
b03f21f to
6ac668c
Compare
holmanb
force-pushed
the
holmanb/url-helper-fix
branch
2 times, most recently
from
a5c0a88 to
9ff55c5
Compare
holmanb
force-pushed
the
holmanb/url-helper-fix
branch
from
9ff55c5 to
db94e90
Compare
Member
Author
|
@TheRealFalcon Assuming the last commit for black formatting, I think this is ready for re-review. |
TheRealFalcon
approved these changes
May 11, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
LGTM...and I think you had a little too much fun with the text in your tests 😄
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging something that uses the dual_stack() function, I noticed that exceptions are not being logged as originally intended.
All exceptions thrown from futures in dual_stack() should be logged for debugging purposes.